Add component wrapper helper to textarea #4574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2025
AshGDS
reviewed
Jan 21, 2025
| @@ -102,7 +102,7 @@ examples: | |||
| <%= component %> | |||
| <% end %> | |||
| data: | |||
| id: "contextual-guidance-id" | |||
| textarea_id: "contextual-guidance-id" | |||
| label: | |||
| text: "Title" | |||
| bold: true | |||
There was a problem hiding this comment.
This file needs the uses_component_wrapper_helper: true line
There was a problem hiding this comment.
Thanks, have added. Looking into the visual diff now 👍
andysellick
force-pushed
the
textarea-cw
branch
2 times, most recently
from
6c9a01e to
8be3d17
Compare
andysellick
force-pushed
the
textarea-cw
branch
from
8be3d17 to
74d73f7
Compare
andysellick
force-pushed
the
textarea-cw
branch
from
74d73f7 to
9441b86
Compare
andysellick
force-pushed
the
textarea-cw
branch
from
2ac455e to
fc77102
Compare
andysellick
force-pushed
the
textarea-cw
branch
from
99cc33b to
a96a8d0
Compare
andysellick
force-pushed
the
textarea-cw
branch
from
a96a8d0 to
a43724a
Compare
|
@AshGDS finally fixed the visual diff - there was a surprisingly complex thing happening with the textarea and the elements that followed it, but I think I've finally got it 👍 |
- breaking change, renames `id` option to `textarea_id` as this is applied to a child element and `id` is applied to the parent by the component wrapper - removes the shared helper, instead relying on the component wrapper helper to provide the same functionality - removes a bit of code that sets the margin back to normal if an invalid value is passed, but this outcome is now handled by the component wrapper
- also improve tests, remove redundant data attributes test (component doesn't accept data attributes)
andysellick
changed the title
andysellick
force-pushed
the
textarea-cw
branch
from
a43724a to
876fc91
Compare
unoduetre
added a commit
that referenced
this pull request
Jan 22, 2025
* Remove margin top from search component ([PR #4581](#4581)) * **BREAKING** Add component wrapper helper to textarea ([PR #4574](#4574)) * Remove margin top from print link ([PR #4577](#4577)) * **BREAKING** Use component wrapper on print link component ([PR #4576](#4576)) * Refactor single page notification component ([PR #4501](#4501)) * Remove shared helper from button component ([PR #4569](#4569)) * Remove shared helper from inset text component ([PR #4571](#4571)) * Use component wrapper on contextual footer ([PR #4562](#4562)) * Update Govspeak "Warning Text" component styles ([PR #4487](#4487)) * Make "Add another" component styles more specific ([PR #4579](#4579)) * Translate "and" connective in metadata component to Chinese, Russian and Arabic ([PR #4580](#4580))
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Apply the component wrapper helper to the textarea component.
idoption totextarea_idas this is applied to a child element andidis applied to the parent by the component wrappermargin_bottomTo deal with this breaking change, other PRs will need to be raised in applications as follows ahead of deployment.
idoption collections-publisher#2373ididThis change also impacts the character count component, which wraps the textarea component. The character count component accepts an
idoption, which is then passed to the textarea to be the id of the textarea element (not the component id). I've updated the component to explicitly pass this when it exists, because there was a corner case where passing an id as part of the textarea object overwrote the value of id passed directly to character count. Hopefully the tests clarify this behaviour (without causing a breaking change to the character count component).Why
The code for
margin_bottomis moving from the shared helper to the component wrapper helper, so we need to remove any instance of this before the work can be completed. Additionally, having the component wrapper on a component helps reduce code and maintenance effort.Visual Changes
None.
Trello card: https://trello.com/c/GQ1p2oSC/438-not-doing-add-component-wrapper-helper-to-form-textarea-component